Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enforce correct TypeScript types for dependent-usage.json object #2951

Merged
merged 1 commit into from
Dec 19, 2023
Merged

chore: enforce correct TypeScript types for dependent-usage.json object #2951

merged 1 commit into from
Dec 19, 2023

Conversation

viktorrusakov
Copy link
Contributor

@viktorrusakov viktorrusakov commented Dec 19, 2023 •
edited
Loading

Description

Fixes a bug with types for dependent-usage.json file, see rationale for the solution in this comment

Deploy Preview

Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 19, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @viktorrusakov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@netlify Netlify
Copy link

netlify bot commented Dec 19, 2023 •
edited
Loading

✅ Deploy Preview for paragon-openedx ready!

Name Link
🔨 Latest commit a670550
🔍 Latest deploy log https://app.netlify.com/sites/paragon-openedx/deploys/658154f42c123700088e8089
😎 Deploy Preview https://deploy-preview-2951--paragon-openedx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40aea5e) 92.83% compared to head (a670550) 92.83%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2951   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         235      235           
  Lines        4245     4245           
  Branches     1032     1032           
=======================================
  Hits         3941     3941           
  Misses        300      300           
  Partials        4        4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This was referenced Dec 19, 2023
Closed
Closed
@viktorrusakov viktorrusakov merged commit a5a37ec into master Dec 19, 2023
10 checks passed
@viktorrusakov viktorrusakov deleted the rusakov/fix-types-for-dependent-usage branch December 19, 2023 09:11
@openedx-webhooks
Copy link

@viktorrusakov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 21.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@openedx-semantic-release-bot
Copy link

🎉 This PR is included in version 22.0.0-alpha.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

khudym pushed a commit to khudym/paragon that referenced this pull request Jan 2, 2024
@viktorrusakov
chore: enforce correct TypeScript types for dependent-usage.json obje…
ac447aa 
…ct (openedx#2951)
@brian-smith-tcril brian-smith-tcril mentioned this pull request Jan 5, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

@PKulkoRaccoonGang PKulkoRaccoonGang PKulkoRaccoonGang approved these changes

@adamstankiewicz adamstankiewicz Awaiting requested review from adamstankiewicz

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U released on @alpha released
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@viktorrusakov @openedx-webhooks @openedx-semantic-release-bot @PKulkoRaccoonGang @brian-smith-tcril